-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snowflake] test types for unit testing #896
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
The two unrelated, failed test cases on the dbt version was an issue in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on some quick local testing 🎩 with this branch, I think we need to incorporate some of the logic from #839 for the unstructed (variant/array/object) types — but I could be mistaken! (especially since I'm having trouble running the adapter functional tests locally)
That PR also included an update that mapped FIXED
→ NUMERIC
types. I don't remember exactly why it was needed for unit tests, but it did have the nice side-effect of a clearer error message for model contract type mismatches.
resolves #898
resolves #891
docs dbt-labs/docs.getdbt.com/#
Problem
Solution
Checklist